Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding Instagram account to social media profile #490

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sergiorgiraldo
Copy link

@sergiorgiraldo sergiorgiraldo commented Jul 17, 2019

What is the purpose of this Pull Request?
It allows instagram accounts to be stored and presented for each congressman. That's another layer for checking expenses, tracking if there are photos to support or debunk them.

What was done to achieve this purpose?
pretty straightforward, added a column in the database and renders this info in the grid.

How to test if it really works?
add an instagram account for a congressman who has expenses to be reviewed. The link for the account must be presented in jarbas under the social column.

Who can help reviewing it?

TODO
Prepare a bulk insert with instagram accounts.

@sergiorgiraldo
Copy link
Author

Issue raised by codeclimate wont be fixed as the extra code is needed.

Copy link
Collaborator

@cuducos cuducos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sergiorgiraldo, thanks for the PR. I would like to raise two questions:

  1. Regarding your comment on Code Climate report (wont be fixed as the extra code is needed), have you considered refactoring the module (not the file)? I do think avoiding too long files is a good strategy in terms of maintenance and I would not dissmis the refactor suggestion just because extra code is needed. In this case, the jarbas/dashboard/admin/__init__.py have two long described models (ReimbursementModelAdmin and ReimbursementSummaryModelAdmin) that could live in different files for a better organization, for example. Maybe 1dcfdb7 could inspire some changes.
  2. Regarding the TODO to prepare a bulk insert with Instagram accounts, do you know any source for this information?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants