Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses Django Public Admin package #524

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cuducos
Copy link
Collaborator

@cuducos cuducos commented Apr 4, 2020

What is the purpose of this Pull Request?

I extract jarbas.public_admin as a pip installable so we can use it in other civic tech projects (e.g., DadosAbertosDeFeira/maria-quiteria#65), this this code can be maintained outside Serenata if needed.

What was done to achieve this purpose?

I replaced the jarbas.public_admin by the external package.

How to test if it really works?

Basically nothing i supopsed to change, the dashboard should still be read-only and public accessible.

TODO

I'm still refining the external package, but I tested locally with Jarbas and it worked, so I'm sharing the code, but we can only merge this once I publish the package to PyPI (that's why it's still a draft PR). Done.

@cuducos cuducos force-pushed the cuducos-use-public-admin-pkg branch 4 times, most recently from c1045e6 to d6f6490 Compare April 4, 2020 18:26
@cuducos cuducos force-pushed the cuducos-use-public-admin-pkg branch from d6f6490 to fa0ee1a Compare April 5, 2020 01:57
@cuducos cuducos marked this pull request as ready for review April 5, 2020 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant