docs: move license from README.md to LICENSE.md #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bufferoverflow
force-pushed
the
docs/seperate_license
branch
from
be718f8
to
27bff76
Compare
|
How about adding a link to the license file in |
bufferoverflow
force-pushed
the
docs/seperate_license
branch
from
27bff76
to
58d43eb
Compare
|
Here is the updated commit, what about the Authors at the end of README.md and within omniauth-saml.gemspec ? Shall we combine this somehow? Any idea? Shall omniauth-saml.gemspec contain the same people as on https://rubygems.org/gems/omniauth-saml ? |
|
I'm not sure who should be listed as authors in the Gemspec and on Rubygems.org. I don't think that needs to be resolved in this PR. Perhaps it would make sense to discuss that at #67 instead. |
|
@md5 yes, you are right that's a separate topic. So I suggest you merge this. |
md5
added a commit
that referenced
this pull request
Feb 16, 2016
docs: move license from README.md to LICENSE.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A widely adopted best practice is having a LICENSE.md file, so I've moved the license out from README.md to a dedicated file.