Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add amidation dataset #175

Merged
merged 7 commits into from
Aug 31, 2023

Conversation

beef-broccoli
Copy link
Contributor

Dataset of a amide coupling reaction with various activators, bases, solvents.

Associated with publication, Fig. 5 and related texts in the manuscript. Experimental details can be found in SI Section 10.

Reaction template, result spreadsheet and dataset pbtxt files are also included.

submission 08-21-23.zip

@connorcoley
Copy link
Contributor

Thanks!!

It is not essential to make this change, but the pre-stirring for 30 minutes before addition of amine could be represented by the addition_time field for the amine input. The addition_order is the typical thing to specify, as you've done, but there's even more detail that could be included with addition_time. That would let us set conditions_are_dynamic back to False.

The SI specifies "overnight", which in the template is 16 hours while Figure 5 shows 24 hours -- do you know which it should be? Everything else looks perfect to me in terms of procedure. I spot checked a few structures only.

@connorcoley connorcoley changed the base branch from main to 175 August 30, 2023 14:48
@beef-broccoli
Copy link
Contributor Author

Thanks for the feedback! Addition time is changed for the amine, and reaction time is corrected to 24 hours (i guess our procedure also was not clear on reaction time).

One potential issue i spotted is for some of the products, maybe because of the conversion from inchi to smiles, the amide structure sometimes show up weird, with the double bond put on the C-N bond. Only some of the structures have this issue. Is this something we want to fix? I can try to clean it up

@connorcoley
Copy link
Contributor

connorcoley commented Aug 30, 2023

Oh that's a good call. Roundtripping an iminol through RDKit won't automatically convert it to the main amide tautomer. It might be nice to do that conversion now, when we know it's "safe", as opposed to expecting downstream users to. It will also help with search/etc.

You should be able to do this with...

import rdkit.Chem as Chem
from rdkit.Chem.MolStandardize import rdMolStandardize
new_mol = rdMolStandardize.CanonicalTautomer(Chem.MolFromSmiles(smi))
new_smi = Chem.MolToSmiles(new_mol)

(assuming there are no other ambiguous/nonstandard substructures in the products)

@beef-broccoli
Copy link
Contributor Author

beef-broccoli commented Aug 31, 2023

All the amide structures are fixed! Thanks for the help

submission 08-31-23.zip

@connorcoley connorcoley merged commit 15a28c5 into open-reaction-database:175 Aug 31, 2023
4 checks passed
@beef-broccoli beef-broccoli deleted the amidation branch August 31, 2023 19:08
connorcoley added a commit that referenced this pull request Sep 6, 2023
* add amidation dataset (#175)

* add amidation dataset

* add dataset pbtxt file

* Delete dataset.pbtxt

* Delete data_dataset.pbtxt

* Add files via upload

* Delete dataset.pbtxt

* add dataset, with name and description

* Update submission

* Update badges

---------

Co-authored-by: beef-broccoli <[email protected]>
Co-authored-by: github-actions <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants