-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add amidation dataset #175
add amidation dataset #175
Conversation
Thanks!! It is not essential to make this change, but the pre-stirring for 30 minutes before addition of amine could be represented by the The SI specifies "overnight", which in the template is 16 hours while Figure 5 shows 24 hours -- do you know which it should be? Everything else looks perfect to me in terms of procedure. I spot checked a few structures only. |
Thanks for the feedback! Addition time is changed for the amine, and reaction time is corrected to 24 hours (i guess our procedure also was not clear on reaction time). One potential issue i spotted is for some of the products, maybe because of the conversion from inchi to smiles, the amide structure sometimes show up weird, with the double bond put on the C-N bond. Only some of the structures have this issue. Is this something we want to fix? I can try to clean it up |
Oh that's a good call. Roundtripping an iminol through RDKit won't automatically convert it to the main amide tautomer. It might be nice to do that conversion now, when we know it's "safe", as opposed to expecting downstream users to. It will also help with search/etc. You should be able to do this with...
(assuming there are no other ambiguous/nonstandard substructures in the products) |
All the amide structures are fixed! Thanks for the help |
* add amidation dataset (#175) * add amidation dataset * add dataset pbtxt file * Delete dataset.pbtxt * Delete data_dataset.pbtxt * Add files via upload * Delete dataset.pbtxt * add dataset, with name and description * Update submission * Update badges --------- Co-authored-by: beef-broccoli <[email protected]> Co-authored-by: github-actions <[email protected]>
Dataset of a amide coupling reaction with various activators, bases, solvents.
Associated with publication, Fig. 5 and related texts in the manuscript. Experimental details can be found in SI Section 10.
Reaction template, result spreadsheet and dataset pbtxt files are also included.
submission 08-21-23.zip