fixed ui issue and content overlapping on login screen #2053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and added default languages
|
@PC-11-00 @alberto-art3ch , please review |
|
Hi I'm just curious how was this tested? Were you able to run login-form.component.spec.ts? |
|
Hi @pcchen1, |
|
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. |
|
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. |
|
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the layout of the login screen and removed overlapping content
Added languages in the default language dropdown on settings screen
Related issues and discussion
#2038 and #2039
Screenshots, if any
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
If you have multiple commits please combine them into one commit by squashing them.
Read and understood the contribution guidelines at
web-app/.github/CONTRIBUTING.md.