Migrate from the deprecated TSLint to Angluar ESLint #2175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate from the deprecated TSLint to Angluar ESLint. Also fix current linting issues in the code, in particular: - Use strict equals operators (=== and !==) - Remove empty lifecycle methods (mostly ngOnInit) - Output bindings including aliases should not be named as standard dom events (submit) - Async pipe results should not be negated
rhopman
force-pushed
the
migrate-tslint-to-eslint
branch
from
522f6d6
to
12365f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TSLint was deprecated by its creators in 2019. This PR replaces Codelyzer and TSLint with Angular ESLint, as recommended in the deprecation notice.
I followed the steps in Migrating from TSLint: Current Status as of angular-eslint v16 to migrate.
To resolve linting errors, I made the following code fixes:
@angular-eslint/template/eqeqeq, I replaced==and!=operators with===and!==respectively, after verifying each occurrence to make sure that there would be no functional impact.@angular-eslint/no-empty-lifecycle-method(Lifecycle methods should not be empty), I removed all empty lifecycle methods (mostlyngOnInit).@angular-eslint/no-output-native(Output bindings, including aliases, should not be named as standard DOM events), I renamed@Output() submitto@Output() submitEvent.@angular-eslint/template/no-negated-async(Async pipe results should not be negated), I changed!(isHandset$ | async)to(isHandset$ | async) === falseinshell.component.html.After the above fixes,
npx ng lintruns without issues.Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
If you have multiple commits please combine them into one commit by squashing them.
Read and understood the contribution guidelines at
web-app/.github/CONTRIBUTING.md.