Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update utils.py #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update utils.py #64

wants to merge 1 commit into from

Conversation

NomsterDude
Copy link

Removed the need to import math by implementing another method to calculate a sqrt.

Removed the need to import math by implementing another method to calculate a sqrt.
@sleroq
Copy link

sleroq commented Jun 11, 2022

But why?

@zaaachos
Copy link

But why?

he wanted to contribute to this code someway hahaha

@NomsterDude
Copy link
Author

But why?

Removes the need for an import and improves efficiency, even if not by much.

Copy link

@MACHONEJ82 MACHONEJ82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@NomsterDude
Copy link
Author

You didn't suggest any changes.

@gabrielnoal
Copy link

Hi guys, I was just looking some PR's to see if there was any new improvement and found this.
I am not sure but I believe that math.sqrt gives you and porper error if the sqrt is negative, and @NomsterDude 's changes could fail withou and proper error.
Hope I've helped 👍🏼

@NomsterDude
Copy link
Author

Hi guys, I was just looking some PR's to see if there was any new improvement and found this.
I am not sure but I believe that math.sqrt gives you and porper error if the sqrt is negative, and @NomsterDude 's changes could fail withou and proper error.
Hope I've helped 👍🏼

Good to know! Thanks for the reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants