[Broadlink] Initial contribution #16273
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsiepel
added
the
new binding
AntonJansen
force-pushed
the
broadlink-binding-4.2.x
branch
from
8264a68
to
9db5bef
Compare
Signed-off-by: AntonJansen <[email protected]>
…nes. Signed-off-by: AntonJansen <[email protected]>
…will work. Signed-off-by: AntonJansen <[email protected]>
AntonJansen
force-pushed
the
broadlink-binding-4.2.x
branch
from
633a698
to
3acad3f
Compare
Signed-off-by: AntonJansen <[email protected]>
- a reference to https:// that should have been http:// for xsi:schemaLocation - a double copyright reference - an empty line that should not be there Signed-off-by: AntonJansen <[email protected]>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/oh-4-0-4-broadlink-binding-rm3-mini-error/152173/16 |
lsiepel
changed the title
- Add new device type to model mapper - Fix bug with mac address being send in wrong order - Added trace logging information to track messages Signed-off-by: AntonJansen <[email protected]>
Cleaned up the code. Signed-off-by: AntonJansen <[email protected]>
…tion. Signed-off-by: AntonJansen <[email protected]>
Signed-off-by: AntonJansen <[email protected]>
Signed-off-by: AntonJansen <[email protected]>
Signed-off-by: AntonJansen <[email protected]>
Skinah
requested changes
Jan 27, 2024
There was a problem hiding this comment.
Please go through all uses of the logger and fix.
Also after you have built the binding look in the target folder where the jar appears.
Folder called target\code-analysis
open the file called report.html
Then try and fix as many as you can whilst you wait for more review comments.
Thanks for taking on the binding.
...inding.broadlink/src/main/java/org/openhab/binding/broadlink/handler/BroadlinkA1Handler.java
Outdated
Show resolved
Hide resolved
...broadlink/src/main/java/org/openhab/binding/broadlink/handler/BroadlinkBaseThingHandler.java
Outdated
Show resolved
Hide resolved
...broadlink/src/main/java/org/openhab/binding/broadlink/handler/BroadlinkBaseThingHandler.java
Outdated
Show resolved
Hide resolved
...broadlink/src/main/java/org/openhab/binding/broadlink/handler/BroadlinkBaseThingHandler.java
Outdated
Show resolved
Hide resolved
...broadlink/src/main/java/org/openhab/binding/broadlink/handler/BroadlinkBaseThingHandler.java
Outdated
Show resolved
Hide resolved
...broadlink/src/main/java/org/openhab/binding/broadlink/handler/BroadlinkBaseThingHandler.java
Outdated
Show resolved
Hide resolved
...broadlink/src/main/java/org/openhab/binding/broadlink/handler/BroadlinkBaseThingHandler.java
Outdated
Show resolved
Hide resolved
...broadlink/src/main/java/org/openhab/binding/broadlink/handler/BroadlinkBaseThingHandler.java
Outdated
Show resolved
Hide resolved
...broadlink/src/main/java/org/openhab/binding/broadlink/handler/BroadlinkBaseThingHandler.java
Outdated
Show resolved
Hide resolved
…b/binding/broadlink/handler/BroadlinkA1Handler.java Reducing trace / debug logging to confirm to logging policy. Co-authored-by: Matthew Skinner <[email protected]> Signed-off-by: Anton Jansen <[email protected]>
…b/binding/broadlink/handler/BroadlinkBaseThingHandler.java Reducing trace / debug logging to confirm to logging policy. Co-authored-by: Matthew Skinner <[email protected]> Signed-off-by: Anton Jansen <[email protected]>
…b/binding/broadlink/handler/BroadlinkBaseThingHandler.java Reducing trace / debug logging to confirm to logging policy. Co-authored-by: Matthew Skinner <[email protected]> Signed-off-by: Anton Jansen <[email protected]>
…b/binding/broadlink/handler/BroadlinkBaseThingHandler.java Reducing trace / debug logging to confirm to logging policy. Co-authored-by: Matthew Skinner <[email protected]> Signed-off-by: Anton Jansen <[email protected]>
…b/binding/broadlink/handler/BroadlinkBaseThingHandler.java Reducing trace / debug logging to confirm to logging policy. Co-authored-by: Matthew Skinner <[email protected]> Signed-off-by: Anton Jansen <[email protected]>
…b/binding/broadlink/handler/BroadlinkBaseThingHandler.java Reducing trace / debug logging to confirm to logging policy. Co-authored-by: Matthew Skinner <[email protected]> Signed-off-by: Anton Jansen <[email protected]>
…b/binding/broadlink/handler/BroadlinkBaseThingHandler.java Ensure actual message is included in logging Co-authored-by: Matthew Skinner <[email protected]> Signed-off-by: Anton Jansen <[email protected]>
…b/binding/broadlink/handler/BroadlinkBaseThingHandler.java Reducing trace / debug logging to confirm to logging policy. Co-authored-by: Matthew Skinner <[email protected]> Signed-off-by: Anton Jansen <[email protected]>
Signed-off-by: AntonJansen <[email protected]>
Signed-off-by: AntonJansen <[email protected]>
Signed-off-by: AntonJansen <[email protected]>
Signed-off-by: AntonJansen <[email protected]>
Co-authored-by: lsiepel <[email protected]> Signed-off-by: Anton Jansen <[email protected]>
…F/config/rm-config.xml Co-authored-by: lsiepel <[email protected]> Signed-off-by: Anton Jansen <[email protected]>
…F/config/rm-config.xml Co-authored-by: lsiepel <[email protected]> Signed-off-by: Anton Jansen <[email protected]>
…F/config/config.xml Co-authored-by: lsiepel <[email protected]> Signed-off-by: Anton Jansen <[email protected]>
…F/config/rmpro-config.xml Co-authored-by: lsiepel <[email protected]> Signed-off-by: Anton Jansen <[email protected]>
…F/config/rmpro-config.xml Co-authored-by: lsiepel <[email protected]> Signed-off-by: Anton Jansen <[email protected]>
Co-authored-by: lsiepel <[email protected]> Signed-off-by: Anton Jansen <[email protected]>
…b/binding/broadlink/internal/handler/BroadlinkRemoteHandler.java Co-authored-by: lsiepel <[email protected]> Signed-off-by: Anton Jansen <[email protected]>
Co-authored-by: lsiepel <[email protected]> Signed-off-by: Anton Jansen <[email protected]>
…b/binding/broadlink/internal/handler/BroadlinkStatusException.java Co-authored-by: lsiepel <[email protected]> Signed-off-by: Anton Jansen <[email protected]>
Co-authored-by: lsiepel <[email protected]> Signed-off-by: Anton Jansen <[email protected]>
Co-authored-by: lsiepel <[email protected]> Signed-off-by: Anton Jansen <[email protected]>
Co-authored-by: lsiepel <[email protected]> Signed-off-by: Anton Jansen <[email protected]>
Co-authored-by: lsiepel <[email protected]> Signed-off-by: Anton Jansen <[email protected]>
…b/binding/broadlink/internal/handler/BroadlinkAuthenticationException.java Co-authored-by: lsiepel <[email protected]> Signed-off-by: Anton Jansen <[email protected]>
Co-authored-by: lsiepel <[email protected]> Signed-off-by: Anton Jansen <[email protected]>
Co-authored-by: lsiepel <[email protected]> Signed-off-by: Anton Jansen <[email protected]>
…hab-addons into broadlink-binding-4.2.x
…b/binding/broadlink/internal/handler/BroadlinkSocketModel2Handler.java Co-authored-by: lsiepel <[email protected]> Signed-off-by: Anton Jansen <[email protected]>
…hab-addons into broadlink-binding-4.2.x
|
I guess the commits where made through the Github web interface. When not properly configured, this causes the DCO to fail because of missing signoff. Unfortunately the suggestions had some whitespace issues so spotless is also complaining. Hopefully you manage to rewrite the commit messages with a signoff and fix the spotless issue. I would also ask you to have a test run after all these change have been applied. It will not be the first and last time my suggestions lead to regression. |
Co-authored-by: lsiepel <[email protected]> Signed-off-by: Anton Jansen <[email protected]>
…F/thing/rm-types.xml Co-authored-by: lsiepel <[email protected]> Signed-off-by: Anton Jansen <[email protected]>
…F/thing/channels.xml Co-authored-by: lsiepel <[email protected]> Signed-off-by: Anton Jansen <[email protected]>
…hab-addons into broadlink-binding-4.2.x
…ing issues. Signed-off-by: AntonJansen <[email protected]>
|
@lsiepel I should have addressed all your comments now. The main thing left is the DCO, which is due to Ricardo Larranaga, which did not use the proper sign-off. I have been trying to reach him the last 6 months, but no luck thus far. |
Signed-off-by: AntonJansen <[email protected]>
I’ll try to have another look next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Description
The binding support the following devices:
This pull request is an update of the stalled pull request #14582, updated for 4.2.x
The discussion for this pull request is:
https://community.openhab.org/t/broadlink-binding-4-1-0-4-2-0/154734
Signed-off-by: Anton Jansen [email protected]