[tacmi] Unit of Measurement fixes, added missing DateTime support #17481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvkis
force-pushed
the
tacmi/improvements-2
branch
from
8926694
to
c8e49ef
Compare
The German locale uses a comma as a separator for decimal numbers, which means that the C.M.I. only uses the full number. Signed-off-by: Christian Niessner <[email protected]>
Also update channels when channelType's change due to UoM changes Signed-off-by: Christian Niessner <[email protected]>
Signed-off-by: Christian Niessner <[email protected]>
marvkis
force-pushed
the
tacmi/improvements-2
branch
from
c8e49ef
to
1f6c2c6
Compare
|
I had a look at the changes, however, as I still have a UVR 1611 and do not use the API Schema, I can't really review them in detail. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The changes should fix [tacmi] Error parsing API Scheme: Non-terminating decimal expansion; no exact representable decimal result #12445
Finally (the 3rd commit) adds support for the time values provided by the C.M.I.. Since only hour/minutes are provided, the current day is used for the date part in the DateTimeType.
Bye,
chris