Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] CONSOLE-4119: Convert deprecated perspective dropdown to select #14328

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sg00dwin
Copy link
Member

@sg00dwin sg00dwin commented Sep 25, 2024

I have the deprecated dropdown switched to use a PatternFly Select and it's functioning, but there is a strange glitching behavior with the menu on select of a different perspective. See animated screen gif at half speed.

Perspective-glitch

Link to quicktime movie for reference

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 25, 2024
@openshift-ci openshift-ci bot added the component/core Related to console core functionality label Sep 25, 2024
Copy link
Contributor

openshift-ci bot commented Sep 25, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sg00dwin
Once this PR has been reviewed and has the lgtm label, please assign jerolimov for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sg00dwin
Copy link
Member Author

/retest

@openshift-ci openshift-ci bot added the kind/cypress Related to Cypress e2e integration testing label Sep 25, 2024
Copy link
Contributor

openshift-ci bot commented Sep 26, 2024

@sg00dwin: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sg00dwin sg00dwin changed the title [WIP] Convert deprecated perspective dropdown to select [WIP] CONSOLE-4119: Convert deprecated perspective dropdown to select Oct 1, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 1, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 1, 2024

@sg00dwin: This pull request references CONSOLE-4119 which is a valid jira issue.

In response to this:

I have the deprecated dropdown switched to use a PatternFly Select and it's functioning, but there is a strange glitching behavior with the menu on select of a different perspective. See animated screen gif at half speed.

Perspective-glitch

Link to quicktime movie for reference

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sg00dwin
Copy link
Member Author

sg00dwin commented Oct 1, 2024

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 1, 2024

@sg00dwin: This pull request references CONSOLE-4119 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/core Related to console core functionality do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/cypress Related to Cypress e2e integration testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants