Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODC-7680: Migrate ResultsList to PF5 #14343

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

logonoff
Copy link
Member

@logonoff logonoff commented Sep 27, 2024

Fixes:

https://issues.redhat.com/browse/ODC-7680

Solution Description:

Migrate ResultsList to PF5

Screen shots / Gifs for design review:

Screencast.from.2024-09-27.13-37-14.mp4

Unit test coverage report:

unchanged

Test setup:

n/a

Browser conformance:

  • Chrome
  • Firefox
  • Safari

This pr is 2/? of ODC-7680 story as each file is being split into a separate PR.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 27, 2024

@logonoff: This pull request references ODC-7680 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Fixes:

https://issues.redhat.com/browse/ODC-7680

Solution Description:

Migrate ResultsList to PF5

I commented out the input validation UI because it is not supported in our currently installed version of PatternFly

Screen shots / Gifs for design review:

Screencast.from.2024-09-27.13-37-14.mp4

Unit test coverage report:

unchanged

Test setup:

n/a

Browser conformance:

  • Chrome
  • Firefox
  • Safari

This pr is 2/? of ODC-7680 story as each file is being split into a separate PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 27, 2024
Copy link
Contributor

openshift-ci bot commented Sep 27, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: logonoff
Once this PR has been reviewed and has the lgtm label, please assign debsmita1 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the component/pipelines Related to pipelines-plugin label Sep 27, 2024
@logonoff
Copy link
Member Author

/retest

Copy link
Contributor

openshift-ci bot commented Sep 28, 2024

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 28, 2024

@logonoff: This pull request references ODC-7680 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Fixes:

https://issues.redhat.com/browse/ODC-7680

Solution Description:

Migrate ResultsList to PF5

Screen shots / Gifs for design review:

Screencast.from.2024-09-27.13-37-14.mp4

Unit test coverage report:

unchanged

Test setup:

n/a

Browser conformance:

  • Chrome
  • Firefox
  • Safari

This pr is 2/? of ODC-7680 story as each file is being split into a separate PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/pipelines Related to pipelines-plugin jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants