Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Troubleshoot/Fix Buffered Reader Closed Stream Bug #39

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

ndegwamartin
Copy link

  • Fix Buffered Reader Closed Stream Bug
  • Refactor Permission Checker to handle String type Ids
  • Remove invocations of EntityUtils.toString(entity, "UTF-8");
  • Tix Typo in LocationHierarchy endpoint processing

- Refactor Permission Checker to handle String type Ids
- Remove invocations of EntityUtils.toString(entity, "UTF-8");
@rehammuzzamil
Copy link

Thanks @ndegwamartin .
PR looks good to me, however we need to find a way to parse HttpResponse to relevant FHIR Entities, as mentioned before the use of gson and Jackson libraries were not working.

I will try that again. Thanks.

@ndegwamartin
Copy link
Author

Thanks @ndegwamartin . PR looks good to me, however we need to find a way to parse HttpResponse to relevant FHIR Entities, as mentioned before the use of gson and Jackson libraries were not working.

I will try that again. Thanks.

What were the issues faced with the above two libraries?

@ndegwamartin
Copy link
Author

@rehammuzzamil I've reinstated the logging for the entity content. We probably need to test out the performance implications of this approach and its impact to the overall implementation.

@rehammuzzamil rehammuzzamil merged commit f18ae67 into 2213-prac-details Jul 17, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants