Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add field bridge:name=* and tunnel:name=* #1273

Open
wants to merge 33 commits into
base: main
Choose a base branch
from

Conversation

SteveLz
Copy link
Contributor

@SteveLz SteveLz commented Jun 26, 2024

Wiki:
bridge:name taginfo
tunnel:name taginfo
These fields are used to record the names of bridges and tunnels on highways, railways, and waterways. Many mappers write the names of bridges and tunnels on the road names because they do not see these field.

Copy link

🍱 You can preview the tagging presets of this pull request here.

@tordans
Copy link
Collaborator

tordans commented Jun 26, 2024

@SteveLz can you please add more context to your PR following the PR template that is drafted in https://github.com/openstreetmap/id-tagging-schema/pull/1239/files
Thanks

@matkoniecz
Copy link
Contributor

matkoniecz commented Jul 7, 2024

No, please please no.

bridge:name is not a good tagging, bridge name should go on man_made=bridge object in name key rather than some unusual tags that is just pointless complexity

@SteveLz
Copy link
Contributor Author

SteveLz commented Jul 7, 2024

  • We may need to be consistent with the bridge:ref that already exists in the id-tagging-schema.
  • The area of ​​a tunnel is difficult to verify, and it is more common for mappers to use tunnel:name instead of drawing an area of ​​indeterminate shape.
  • Compared to writing the names of bridges and tunnels in bridge:name and tunnel:name, it is even more unacceptable to change the name of highways, railways, and waterways to bridges and tunnels. We need to remind people to use man_made=bridge instead of rejecting the tag.

unusual tags

Does this mean that the number of named man_made=bridge is slightly less than bridge:name?

pointless complexity

For places where the bridge lines have not yet been fully identified and the railways have not yet been fully double-tracked, mapping the bridge area is indeed a labor-intensive micro-mapping. This is again difficult to accomplish for places where up-to-date imagery is not yet available.

@matkoniecz
Copy link
Contributor

The area of ​​a tunnel is difficult to verify, and it is more common for mappers to use tunnel:name instead of drawing an area of ​​indeterminate shape.

note that I have not commented at all about tunnel:name

@matkoniecz
Copy link
Contributor

Does this mean that the number of named man_made=bridge is slightly less than bridge:name?

  1. number of objects where their name is tagged on another object rather in name tag is low compared to usage of name tag in general

  2. note that bridge:name is counted multiple times in many cases for a single bridge

@1ec5
Copy link
Contributor

1ec5 commented Jul 7, 2024

bridge:name is not a good tagging, bridge name should go on man_made=bridge object in name key rather than some unusual tags that is just pointless complexity

These tagging styles aren’t mutually exclusive, are they? I’ve often tagged both since the redundancy didn’t seem to be that harmful.

For what it’s worth, #215 would also mitigate some of the tendency to overload name=*. (Hopefully you don’t look at the date on that PR and despair for this PR’s prospects. 😬)

Copy link
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say, that even though the mapping of bridges as separate objects can be considered the "state of the art" mapping technique, the bridge:name tag is still used often enough to warrant to be represented in the tagging schema (at the very least to make it easy to move the name to it's own feature when newly drawing a bridge's polygon).

@SteveLz what's missing in this PR is the inclusion of the new fields in the respective (road and railway ) presets. I would prefer to include bridge:name only as an optional ("moreFields") field, while tunnel:name might make sense to be included in the list of regular fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants