Always use coordinates when using directions from context menu #5099
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the problem #5064 tries to solve are the result of the context menu using addresses from endpoint inputs.
You right click somewhere, select "Directions from here" and it goes to and url like this:
/directions?from=51.420436%2C-0.174805&to=
. Then you right click somewhere else, select "Directions to here" and the url becomes something like this:/directions?from=Park%20Road%2C%20Collier%27s%20Wood%2C%20London%20Borough%20of%20Merton%2C%20London%2C%20Greater%20London%2C%20England%2C%20SW19%202HT%2C%20United%20Kingdom&to=51.420563%2C-0.171007
. The coordinates infrom
got replaced by an address. It's impossible to get the original coordinates from an address.The solution here is to save the coordinates to
data-lat
anddata-lon
attributes of inputs. The context menu then can generate directions urls using the values stored there.This doesn't solve the entire problem because there's also uncontrolled reverse geocoding decided by Nominatim when using its freeform query.