Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable JavaScript unit tests using Teaspoon #5216

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

kcne
Copy link
Contributor

@kcne kcne commented Sep 14, 2024

This pull request addresses #2595 , which involves re-enabling JavaScript unit tests. The goal is to restore JavaScript testing after the removal of Konacha. This work continues Andy's effort by cherry-picking commits from his branch, where the initial Teaspoon integration began.

Key Updates:

  • Teaspoon Integration: Teaspoon has been configured to use Selenium WebDriver with Firefox (replacing PhantomJS, which is discontinued).
  • GitHub CI: The GitHub test CI script has been updated to run JavaScript tests alongside the Rails tests.
  • ESLint Adjustments: Added ESLint rules for the JavaScript test files in the test folder, fixing a few ESLint errors during the process.

At the moment, some tests are failing, you can look at the logs for more details. This could be due to changes in implementation or other issues that I am investigating. Any advice on how to approach this would be highly appreciated. I also faced some caching problems inside Docker, but those should be resolved now.

Note: This is still work in progress. I just wanted to get some feedback and to confirm this is going into right direction.

@kcne kcne marked this pull request as ready for review September 18, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants