Removed unused translations in changesets namespace #5223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonKhorev
reviewed
Sep 19, 2024
app/views/changesets/show.html.erb
Outdated
| @@ -40,9 +40,10 @@ | |||
| <% next unless comment.visible || current_user&.moderator? %> | |||
| <li id="c<%= comment.id %>"> | |||
| <small class='text-body-secondary'> | |||
| <%= t comment.visible ? ".comment_by_html" : ".hidden_comment_by_html", | |||
| <% comment_info = comment.visible ? "comment_by_html" : "hidden_comment_by_html" %> | |||
| <%= t(".#{comment_info}", | |||
There was a problem hiding this comment.
Looks like once you do t ".#{comment_info}" i18n-tasks stops reporting changesets.show.-anything as missing.
You could have inserted this line with the same effect:
<% t ".#{'shut up'}" %>
AntonKhorev
reviewed
Sep 19, 2024
config/i18n-tasks.yml
Outdated
| @@ -132,6 +132,7 @@ ignore_unused: | |||
| - 'reports.new.categories.*' # double interpolation in reports_helper | |||
| - 'shared.pagination.*' | |||
| - 'auth.providers.*' | |||
| - 'changesets.paging_nav.*' # used by string interpolation in elements pagination | |||
There was a problem hiding this comment.
Won't be required if #4872 is merged, although it uses the same effect as in https://github.com/openstreetmap/openstreetmap-website/pull/5223/files#r1766713701 to some extent.
nenad-vujicic
force-pushed
the
issue_fix_unused_translations_in_changesets
branch
from
306d398
to
3f27dc3
Compare
|
Thanks, I've just made following updates:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR makes following changes: