Skip to content

Commit

Permalink
Fix windows only build failure on include filename.
Browse files Browse the repository at this point in the history
Between eliding third_party directory names in includes, and Windows being case insensitive on header include paths, the following include was ambiguous and resolved to (1), leading to issues in using the StableHLO header:

```
#include "stablehlo/transforms/Passes.h"
// (1) tensorflow/compiler/mlir/lite/stablehlo/transforms/passes.h
// (2) @stablehlo - third_party/stablehlo/stablehlo/transforms/Passes.h
```

PiperOrigin-RevId: 679703637
  • Loading branch information
GleasonK authored and Google-ML-Automation committed Oct 3, 2024
1 parent 06d214a commit 1ce7a49
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
1 change: 0 additions & 1 deletion xla/mlir_hlo/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -1147,7 +1147,6 @@ cc_library(
srcs = [
"stablehlo_ext/transforms/chlo_recompose_ops.cpp",
"stablehlo_ext/transforms/stablehlo_canonicalize_dynamism.cpp",
"stablehlo_ext/transforms/stablehlo_compatibility_expander.cpp",
"stablehlo_ext/transforms/stablehlo_refine_shapes.cpp",
],
hdrs = [
Expand Down
6 changes: 0 additions & 6 deletions xla/mlir_hlo/stablehlo_ext/transforms/passes.h
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,6 @@ namespace stablehlo_ext {

void createChloLegalizeToStablehloPipeline(OpPassManager &pm);

// Expand backward compatibility with the given StableHLO version by decomposing
// newer StableHLO operations into equivalent operations supported by that older
// version.
std::unique_ptr<Pass> createStablehloCompatibilityExpanderPass(
std::string targetVersionOption);

} // namespace stablehlo_ext
} // namespace mlir

Expand Down

0 comments on commit 1ce7a49

Please sign in to comment.