Remove more GPU/CUDA/ROCm attribute guards from xla/service/gpu #16209
+307
−355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_664760472
branch
6 times, most recently
from
e232380
to
8629ab6
Compare
copybara-service
bot
force-pushed
the
test_664760472
branch
3 times, most recently
from
48fd092
to
4c96b7b
Compare
copybara-service
bot
force-pushed
the
test_664760472
branch
12 times, most recently
from
7f0dd63
to
25fd6ba
Compare
- This removes `if_gpu_is_configured` guards from targets that are only supposed to be built for GPU. (Also tags them as `gpu` so that they get automatically excluded from the CPU build) - This removes a bunch of `local_defines = if_cuda_is_configured([GOOGLE_CUDA])` parameters from targets that don't use the `GOOGLE_CUDA` preprocessor definition (anymore). - Same for `TENSORFLOW_USE_ROCM` - It tags many gpu-only targets with `gpu` so that they won't be built in a CPU-only build. PiperOrigin-RevId: 664760472
copybara-service
bot
force-pushed
the
test_664760472
branch
from
25fd6ba
to
02c8648
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove more GPU/CUDA/ROCm attribute guards from xla/service/gpu
if_gpu_is_configuredguards from targets that are only supposed to be built for GPU. (Also tags them asgpuso that they get automatically excluded from the CPU build)local_defines = if_cuda_is_configured([GOOGLE_CUDA])parameters from targets that don't use theGOOGLE_CUDApreprocessor definition (anymore).TENSORFLOW_USE_ROCMgpuso that they won't be built in a CPU-only build.