Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust to number of captures in previous regex #360

Merged
merged 5 commits into from
Jul 31, 2023
Merged

Adjust to number of captures in previous regex #360

merged 5 commits into from
Jul 31, 2023

Commits on Jul 28, 2023

  1. Adjust to number of captures in previous regex

    @haoess @mgautierfr
    haoess authored and mgautierfr committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    3379db0 View commit details
    Browse the repository at this point in the history

  2. Add test on parsing of redirect file. 

    - Refactor code to move parsing code in `parse_redirectArticles`.
- Add test.
    @mgautierfr
    mgautierfr committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    413eca8 View commit details
    Browse the repository at this point in the history

  3. Add gtest wrap in subproject. 

    This way, zim-tools is properly tested even if gtest is not available
in the system.
(This is what is done in libzim and libkiwix)
    @mgautierfr
    mgautierfr committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    7262d3e View commit details
    Browse the repository at this point in the history

  4. fixup! Add test on parsing of redirect file.

    @mgautierfr
    mgautierfr committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    2302871 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. Add test with too many tabs and fix code. 

    `(.+)` is a bit to greedy and matches `\t`.
    @mgautierfr
    mgautierfr committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    e4dc68e View commit details
    Browse the repository at this point in the history