Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Debian to the CI #362

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Add Debian to the CI #362

merged 1 commit into from
Jul 26, 2023

Conversation

kelson42
Copy link
Contributor

@kelson42 kelson42 commented Jul 26, 2023

Add testing of Debian packaging in CI

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a59661e) 27.55% compared to head (cccf202) 27.55%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #362   +/-   ##
=======================================
  Coverage   27.55%   27.55%           
=======================================
  Files          26       26           
  Lines        2519     2519           
  Branches     1344     1344           
=======================================
  Hits          694      694           
  Misses       1354     1354           
  Partials      471      471           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelson42 kelson42 merged commit 06e43a0 into main Jul 26, 2023
10 of 13 checks passed
@kelson42 kelson42 deleted the debian-ci branch July 26, 2023 13:46
@mgautierfr
Copy link
Collaborator

Please don't merge PR when the CI don't pass !

@kelson42
Copy link
Contributor Author

@mgautierfr Yes, sorry, was convinced it was the same everywhere because c++14. I will fix the other.

@mgautierfr
Copy link
Collaborator

Well, what ever is the cause, don't merge PR when the CI don't pass :)

Having a "accepted" CI not passing will make people not looking about the cause when they see a "red" check. This is the best way to merge new bug. The proof: You haven't check what was the cause and merge the PR with "another" bug.
None of the broken PRs (c++14 or other cause) should have been merged.

@kelson42
Copy link
Contributor Author

kelson42 commented Jul 26, 2023

@mgautierfr You are right but now we have to fix the problems in the code in top prio on anything else, which is what I actually wanted as well as I'm synchronising all of this on all cpp repositories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants