Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macOS 14 ARM in the CI #412

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Add macOS 14 ARM in the CI #412

wants to merge 4 commits into from

Conversation

kelson42
Copy link
Contributor

@kelson42 kelson42 commented Jun 2, 2024

We need to check and provide zim-tools on macOS for Mx family

Copy link

codecov bot commented Jun 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.97%. Comparing base (fab5063) to head (9c42cbd).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #412      +/-   ##
==========================================
- Coverage   27.01%   26.97%   -0.05%     
==========================================
  Files          26       26              
  Lines        2458     2458              
  Branches     1339     1340       +1     
==========================================
- Hits          664      663       -1     
  Misses       1305     1305              
- Partials      489      490       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelson42
Copy link
Contributor Author

kelson42 commented Jun 2, 2024

@mgautierfr Why libzim is not available in the dependences?

@mgautierfr
Copy link
Collaborator

PR always require a description 😉

Why libzim is not available in the dependences?

Because you search in x86_64 directories (https://github.com/openzim/zim-tools/pull/412/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fR61-R62) and it is not the right directory for aarch64. It should be BUILD_arm64-apple-macos

@kelson42 kelson42 requested a review from mgautierfr June 3, 2024 09:31
@kelson42 kelson42 marked this pull request as draft June 3, 2024 09:31
@kelson42 kelson42 force-pushed the macos-14-arm-ci branch 8 times, most recently from 38b5dd3 to 159e7a2 Compare June 3, 2024 10:02
@kelson42
Copy link
Contributor Author

kelson42 commented Jun 3, 2024

@mgautierfr Thx, not it seems we face another problem as it seems it is still not able to link properly

@kelson42
Copy link
Contributor Author

@mgautierfr ?

@kelson42
Copy link
Contributor Author

kelson42 commented Aug 6, 2024

@mgautierfr Help needed?

@kelson42
Copy link
Contributor Author

kelson42 commented Aug 24, 2024

@rgaudin Would you be able pleae to confirm that BUILD_arm64-apple-macos/INSTALL/lib/libxapian.a from https://tmp.kiwix.org/ci/deps_macos-aarch64-dyn_zim-tools.tar.gz is a binary made for arm64/aarch74? To me this would be the only explaination behind the error.

@rgaudin
Copy link
Member

rgaudin commented Aug 26, 2024

❯ lipo -info BUILD_arm64-apple-macos/INSTALL/lib/libxapian.a
Non-fat file: BUILD_arm64-apple-macos/INSTALL/lib/libxapian.a is architecture: arm64

It looks like you're missing compression stuff ; probably zlib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants