Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the websocket connection timeout log from warning to fine #301

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

notthetup
Copy link
Collaborator

This log is triggered when the WebSocketConnector cannot send a message to a connected fjage.js Gateway within 500ms.

This tends to happen when a browser initiates a WebSocket connection, but the user is not focused on the browser window that has the connection open.

Also happens when the connection between the browser and the WebSocketConnector is abruptly broken (like loosing WiFi connection, or unplugging an ethernet cable).

1705979634701|WARNING|org.arl.fjage.connectors.WebSocketConnector@27:write|Sending timed out. Closing connection to /192.168.1.106:53581

This PR changes that warning to a fine, since it's not that critical as all fjåge.js clients have retries builtin.

@notthetup notthetup self-assigned this Jan 23, 2024
@notthetup notthetup closed this Jan 25, 2024
@notthetup notthetup reopened this Jan 25, 2024
@notthetup notthetup merged commit 2b2a20e into master Jan 25, 2024
2 checks passed
@notthetup notthetup deleted the websocket-remove-warning branch January 25, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants