Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return timestamps with offset to client for needle info #5964

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

perlpunk
Copy link
Contributor

Issue: https://progress.opensuse.org/issues/167635

Unfortunately this makes t/ui/18-tests-details.t fail, because of a UI problem. The popup is bigger and somehow prevents the click to close the candidates menu.
I can't reproduce it in non headless mode, because I don't know which size the window would have.

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.75%. Comparing base (b638ad7) to head (c54716a).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5964   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files         396      396           
  Lines       38982    38986    +4     
=======================================
+ Hits        38498    38502    +4     
  Misses        484      484           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@perlpunk
Copy link
Contributor Author

oh great, t/ui/18-tests-details.t passes in CI, but not locally.

@perlpunk perlpunk marked this pull request as ready for review September 30, 2024 17:16
@kalikiana
Copy link
Member

kalikiana commented Oct 1, 2024

[  540s] error: %prein(openQA-worker-4.6.1727714485.fb89eea4-7226.2.x86_64) scriptlet failed, exit status 6
[  540s] error: openQA-worker-4.6.1727714485.fb89eea4-7226.2.x86_64: install failed

for openSUSE Tumbleweed x86_64, see poo#167587

@okurz
Copy link
Member

okurz commented Oct 1, 2024

@Mergifyio rebase

Copy link
Contributor

mergify bot commented Oct 1, 2024

rebase

✅ Branch has been successfully rebased

@perlpunk
Copy link
Contributor Author

perlpunk commented Oct 1, 2024

Note: t/ui/18-tests-details.t is failing locally for me consistently with this change. It would be good if someone else could double check:

ok 19 - test candidate list
clickElement: element click intercepted: Element <button id="candidatesMenu" type="button" aria-haspopup="true"
 aria-expanded="true" data-bs-toggle="dropdown" class="btn btn-light dropdown-toggle show">...</button> is
 not clickable at point (448, 579). Other element would receive the click: <div class="popover-body">...</div> at
 ../lib/OpenQA/SeleniumTest.pm:78 at ../lib/OpenQA/SeleniumTest.pm line 81.
        OpenQA::SeleniumTest::__ANON__(Test::Selenium::Chrome=HASH(0x564e48481fe0), "Error while executing
 command: clickElement: element click in"..., HASH(0x564e498fc550)) called at /usr/lib/perl5/vendor_perl/5.26.1/Selenium/Remote/Driver.pm line 356
make test EXTRA_PROVE_ARGS="-v" TESTS=t/ui/18-tests-details.t

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants