Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for delete_needles #5969

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Conversation

perlpunk
Copy link
Contributor

@perlpunk perlpunk commented Oct 1, 2024

Issues:

This tests different failures and also adds coverage for the git part in OpenQA::Schema::Result::Needles.

Trying to make small, easy to review PRs.

@perlpunk perlpunk force-pushed the add-needle-test branch 2 times, most recently from c6b2720 to 87e34f4 Compare October 1, 2024 20:14
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.76%. Comparing base (d621070) to head (d36ff84).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5969   +/-   ##
=======================================
  Coverage   98.75%   98.76%           
=======================================
  Files         396      396           
  Lines       38984    39033   +49     
=======================================
+ Hits        38500    38552   +52     
+ Misses        484      481    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Issues:
* https://progress.opensuse.org/issues/164898
* https://progress.opensuse.org/issues/165393

This tests different failures and also adds coverage for the git part
in OpenQA::Schema::Result::Needles.
Copy link
Member

@kalikiana kalikiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay for more test coverage!

@mergify mergify bot merged commit 9d29acb into os-autoinst:master Oct 2, 2024
45 checks passed
@perlpunk perlpunk deleted the add-needle-test branch October 2, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants