Simplify schedule to create Incident SLES4SAP HDD #20086
Conversation
| # needle check to make sure we are in the correct place and the System Role | ||
| # dialog did not come up. | ||
| assert_screen('partitioning-edit-proposal-button'); | ||
| } |
There was a problem hiding this comment.
Similar to the first elsif, I think it'd be a good idea to add a record_info here indicating that test is skipping the screen/check because there is no system role selection in SLES for SAP 12-SP5
There was a problem hiding this comment.
I will add the record_info
There was a problem hiding this comment.
I will not remove the needle check because the comments reminded me why I added it. It exists because when system_role.pm is run in create_hdd_SLES_gnome, the job we need for migrations, is_sles4sap returns true. So we need to add a check_screen to make sure the system role SCREEN has not come up.
Here is an example where I run is_sles4sap in the sles create_hdd job and it returns true. http://openqaworker15.qa.suse.cz/tests/295826#step/system_role/1
a-kpappas
force-pushed
the
refactor_schedule
branch
from
d4b2439
to
809feab
Compare
a-kpappas
force-pushed
the
refactor_schedule
branch
from
809feab
to
85a1ee6
Compare
The schedule to create the image that all the on-prem SAP specific scenarios are using was complicated because it had: 1. Cases for unsupported versions 2. Workarounds for YAMLs being unable to loop 3. Unused options 4. Nested cases that were always true This commit fixes that by: 1. Removing unsupported versions 2. Modifying system_role.pm to remove the need to unroll a version loop inside the yaml 3. Removing unused options. 4. Moving the cases up the tree. Related Ticket: TEAM-9610 Delete unsupported SLES4SAP version Remove conditionals from the schedule that are always true
a-kpappas
force-pushed
the
refactor_schedule
branch
from
85a1ee6
to
819fd1b
Compare
a-kpappas
requested review from
Amrysliu,
BillAnastasiadis,
jankohoutek,
lilyeyes and
lpalovsky
as code owners
The schedule to create the image that all the on-prem SAP specific scenarios are using was complicated because it had:
This commit fixes that by:
-- FIPS Verification: https://openqa.suse.de/tests/overview?build=apappas-test&distri=sle&version=15-SP6&groupid=605