Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[assertj,cm] Assertions and Conditions on CofigurationEvent #791

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stbischof
Copy link
Contributor

No description provided.

@stbischof
Copy link
Contributor Author

@timothyjward

Could you give me your general thoughts on that.

@timothyjward timothyjward self-requested a review February 7, 2024 10:32
Copy link
Contributor

@timothyjward timothyjward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks promising, but I think it needs tidying up a little. There are a few things which are currently public which I think should probably not be considered API (and therefore need to be default visibility).

@stbischof
Copy link
Contributor Author

stbischof commented Feb 9, 2024

@timothyjward I am Ready with this PR

Here are some examples of how the conditions we publish could describe a Assert-Result:

[✓] pid is <null>


[✗] pid is <null> was <thePid>


[✓] all of:[
   [✓] type is <CM_UPDATED>,
   [✓] factoryPid equals <theFactoryPid>
]


[✗] all of:[
   [✓] type is <CM_UPDATED>,
   [✗] factoryPid equals <otherFactoryPid> was <theFactoryPid>
]


[✗] all of:[
   [✗] type is <CM_DELETED> was <CM_UPDATED>,
   [✓] factoryPid equals <theFactoryPid>
]


[✓] factoryPid is <null>


[✗] factoryPid is <null> was <theFactoryPid>


[✓] type is <CM_UPDATED>


[✗] type is <CM_UPDATED> was <CM_DELETED>


[✓] any of:[
   [✗] all of:[
      [✗] not :<pid is <null>>,
      [✓] pid equals <null>
   ],
   [✓] all of:[
      [✓] not :<factoryPid is <null> was <theFactoryPid>>,
      [✓] factoryPid equals <theFactoryPid>
   ]
]


[✓] any of:[
   [✓] all of:[
      [✓] not :<pid is <null> was <thePid>>,
      [✓] pid equals <thePid>
   ],
   [✗] all of:[
      [✗] not :<factoryPid is <null>>,
      [✓] factoryPid equals <null>
   ]
]


[✗] any of:[
   [✗] all of:[
      [✗] not :<pid is <null>>,
      [✓] pid equals <null>
   ],
   [✗] all of:[
      [✓] not :<factoryPid is <null> was <otherFactoryPid>>,
      [✗] factoryPid equals <theFactoryPid> was <otherFactoryPid>
   ]
]


[✗] any of:[
   [✗] all of:[
      [✓] not :<pid is <null> was <otherPid>>,
      [✗] pid equals <thePid> was <otherPid>
   ],
   [✗] all of:[
      [✗] not :<factoryPid is <null>>,
      [✓] factoryPid equals <null>
   ]
]


[✓] factoryPid equals <theFactoryPid>


[✗] factoryPid equals <theFactoryPid> was <otherFactoryPid>


[✗] factoryPid equals <theFactoryPid> was <null>


[✓] factoryPid equals <thePid>


[✗] factoryPid equals <thePid> was <otherPid>

[✗] factoryPid equals <thePid> was <null>

[✓] all of:[
   [✓] type is <CM_UPDATED>,
   [✓] pid equals <thePid>
]


[✗] all of:[
   [✓] type is <CM_UPDATED>,
   [✗] pid equals <otherPid> was <thePid>
]


[✗] all of:[
   [✗] type is <CM_DELETED> was <CM_UPDATED>,
   [✓] pid equals <thePid>
]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants