Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Costa Rica shields #458

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

Add Costa Rica shields #458

wants to merge 13 commits into from

Conversation

claysmalley
Copy link
Member

Initial support for shields of Costa Rica.

Screenshot from 2022-06-26 16-10-49 Screenshot from 2022-06-26 16-10-21

@ZeLonewolf
Copy link
Member

Route 10111? Is that a real route?

@claysmalley
Copy link
Member Author

Yeah, though it might should be unsigned_ref=10111.

@@ -551,6 +565,9 @@ export function loadShields(shieldImages) {
// Yukon
shields["CA:YT"] = roundedRectShield(Color.shields.white, Color.shields.red);

// Costa Rica
shields["CR:national"] = badgeWithStrokeShield;
Copy link
Member

@1ec5 1ec5 Jun 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

network=CR:national is being tagged on every route in the National Road Network, making no distinctions between primary, secondary, and tertiary routes, even though all three classes have different shields. This is similar to the situation in #455 (comment).

network=CR:national está aplicado en cada ruta de la Red Vial Nacional, sin distinción entre las rutas primarias, secundarias, y terciarias, aunque las tres clasificaciones tienen los señales diferentes. Es similar con la situación en #455 (comment).

Primaria Secundaria Terceraria

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds like a showstopper, right? Don't we have a similar situation in a country in Europe?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think so. We must be able to determine shield appearance from network=*, and three different route shields are all assigned network=CR:national. This would need to be fixed before we can support Costa Rican shields.

Copy link
Member

@1ec5 1ec5 Jun 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@claysmalley claysmalley added blocked mapping Changes needed to OpenStreetMap and removed blocked labels Jun 28, 2022
@claysmalley claysmalley marked this pull request as draft June 28, 2022 13:22
@ZeLonewolf
Copy link
Member

Given the lack of response, I'd say someone could simply define a sensible scheme for Costa Rica's road system. Note that this PR has to get updated to handle the new shape drawing functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants