Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Use new entrypoint for cron worker #4207

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

spencerschrock
Copy link
Contributor

What kind of change does this PR introduce?

cron update

What is the current behavior?

Uses the old pkg.RunScorecard

What is the new behavior (if this is a feature change)?**

Uses the new pkg.Run
There are further simplifications that are possible, but leaving for later to keep this PR small.

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Follow up of #3717

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

NONE

There are further simplifications that are possible,
but leaving for later to keep this PR small.

Signed-off-by: Spencer Schrock <[email protected]>
@spencerschrock
Copy link
Contributor Author

I used the local cron environment to test with a random selection of 50 repos. The results were compared with scdiff and match.

We'll also be able to see how this performs in the release test environment after merging.

@spencerschrock spencerschrock marked this pull request as ready for review July 3, 2024 17:17
@spencerschrock spencerschrock requested a review from a team as a code owner July 3, 2024 17:17
@spencerschrock spencerschrock requested review from justaugustus and raghavkaul and removed request for a team July 3, 2024 17:17
@justaugustus justaugustus enabled auto-merge (squash) July 3, 2024 21:51
@justaugustus justaugustus merged commit d889dcb into ossf:main Jul 3, 2024
36 checks passed
@spencerschrock spencerschrock deleted the migrate-cron branch July 3, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants