Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A story in which #[non_exhaustive] is discovered #535

Merged
merged 4 commits into from
Sep 11, 2023

Conversation

cgwalters
Copy link
Member

tar: Make WriteTarOptions #[non_exhaustive]

To allow future extensibility.


tar: Make TarImportOptions #[non_exhaustive]

To allow future extensibility.


container: Make DeployOpts #[non_exhaustive]

To allow future extensibility.


container: Make ExportOpts #[non_exhaustive]

To allow future extensibility.


@cgwalters cgwalters added the semver-break A change that requires a semver bump label Sep 10, 2023
@jmarrero
Copy link
Member

Looking at https://doc.rust-lang.org/reference/attributes/type_system.html I am not sure what makes this a semver-break but lgtm. Leaving the merge button alone in case you want to merge just before a release.

@cgwalters
Copy link
Member Author

Looking at https://doc.rust-lang.org/reference/attributes/type_system.html I am not sure what makes this a semver-break

Good question! The reason is that it required changes in cli.rs which is like an external consuming crate.

I'm doing these semver changes because we just bumped semver for #532 so it's a good time to make other API cleanups.

@cgwalters
Copy link
Member Author

Sorry I mean not cli.rs in this PR but actually the tests, but those count too
https://github.com/ostreedev/ostree-rs-ext/pull/535/files#diff-1f58fb5f75b6b5943ac35e36d14d2d827bfd5e5f843e8b289aedc73033ffe66bL109-R111

@cgwalters cgwalters merged commit 2781808 into ostreedev:main Sep 11, 2023
8 checks passed
@jmarrero
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-break A change that requires a semver bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants