Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Fix display bug and improve numeric format #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tocky
Copy link

@tocky tocky commented Aug 28, 2013

  • Replace the caption from lowercase to uppercase
  • Each column of numeric type uses right-align
  • Apply comma format to some numerical columns in case of friendly mode

* Replace the caption from lowercase to uppercase
* Each column of numeric type uses right-align
* Apply comma format to some numerical columns in case of friendly mode
table.add_row([p.broker, p.topic, p.partition, p.earliest, p.latest,
fmt(p.depth), p.spout, p.current, fmt(p.delta)])
table.add_row([p.broker, p.topic, p.partition, cfmt(p.earliest),
cfmt(p.latest), fmt(p.depth), p.spout, cfmt(p.current),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer not to have commas by default. Perhaps it could be switch?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okey, I'll try to add 'commify' option newly.

@philip-loggly
Copy link
Contributor

Thanks for the pull request -- one comment.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants