Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pcl ring datatype update #14

Closed
girvenavery2022 opened this issue Mar 12, 2022 · 2 comments · Fixed by #40
Closed

pcl ring datatype update #14

girvenavery2022 opened this issue Mar 12, 2022 · 2 comments · Fixed by #40
Assignees
Labels
enhancement New feature or request

Comments

@girvenavery2022
Copy link

girvenavery2022 commented Mar 12, 2022

OS

  • ubuntu 20.04

Ros

  • noetic

information

The issue I am creating here, goes right along with the issue I created with the Ros2 driver repo (ros-drivers/ros2_ouster_drivers#95). But essentially, the ring data type is defined as a uint8_t and while this doesn't break anything, updating it to a uint16_t has the benefits of increasing the portability of both the Ros1 and Ros2 Ouster Drivers and allowing the users to create more reusable code because ignition gazebo and other 3D lidar drivers use a uint16_t as their ring datatype.
I already have this fix completed and ready to be tested when I get to my Ouster on Monday. I can also make PR with these changes so please let me know if i need to add anything!

@kairenw
Copy link
Contributor

kairenw commented Mar 21, 2022

Hi @girvenavery2022,

Thanks for pointing that out! That makes sense. We would welcome the PR. If so, could you make a note in the CHANGELOG? The big heading would be [Unreleased], and under that if you could just write ouster_ros and then the change under that!

@girvenavery2022
Copy link
Author

Hello!
Awesome, I updated the CHANGELOG on my fork that has the ring type changes and I will open up a PR for it!

@Samahu Samahu transferred this issue from ouster-lidar/ouster-sdk Oct 12, 2022
@Samahu Samahu self-assigned this Nov 15, 2022
@Samahu Samahu added the enhancement New feature or request label Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants