Skip to content

Commit

Permalink
Include msid-semantic in Session Attributes
Browse files Browse the repository at this point in the history
Chrome doesn't include the msid when responding to
recvonly transceivers

See crbug[0] for discussion

[0] https://issues.chromium.org/u/1/issues/328522463
  • Loading branch information
Sean-Der committed Apr 1, 2024
1 parent 659507c commit 92df4bf
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions peerconnection.go
Original file line number Diff line number Diff line change
Expand Up @@ -2318,6 +2318,7 @@ func (pc *PeerConnection) generateUnmatchedSDP(transceivers []*RTPTransceiver, u
if err != nil {
return nil, err
}
d.Attributes = append(d.Attributes, sdp.Attribute{Key: sdp.AttrKeyMsidSemantic, Value: "WMS*"})

iceParams, err := pc.iceGatherer.GetLocalParameters()
if err != nil {
Expand Down Expand Up @@ -2390,6 +2391,7 @@ func (pc *PeerConnection) generateMatchedSDP(transceivers []*RTPTransceiver, use
if err != nil {
return nil, err
}
d.Attributes = append(d.Attributes, sdp.Attribute{Key: sdp.AttrKeyMsidSemantic, Value: "WMS*"})

iceParams, err := pc.iceGatherer.GetLocalParameters()
if err != nil {
Expand Down

0 comments on commit 92df4bf

Please sign in to comment.