test with Pekko 1.1 milestone releases

[pjfanning]

Pull Request Checklist

• Have you read How to write the perfect pull request?
• Have you read through the contributor guidelines?
• Have you referenced any issues you're fixing using commit message keywords?
• Have you added copyright headers to new files?
• Have you checked that both Scala and Java APIs are updated?
• Have you updated the documentation for both Scala and Java sections?
• Have you added tests for any changed functionality?

Helpful things

Fixes

Fixes #xxxx

Purpose

To check on whether Play builds cleanly with Pekko 1.1.0-M1

What does this PR do?

Background Context

Why did you take this approach?

References

Are there any relevant issues / PRs / mailing lists discussions?

[pjfanning]

Issues in these tests.

[error] 	play.api.libs.ws.ahc.AhcWSSpec
[error] 	play.api.data.FormUtilsSpec
[error] 	play.it.libs.PekkoHttpJavaWSSpec
[error] 	play.it.http.parsing.MultipartFormDataParserSpec
[error] 	play.it.libs.PekkoHttpScalaWSSpec
[error] 	play.it.http.parsing.JacksonJsonBodyParserSpec
[error] 	play.it.action.FormActionSpec

[mkurz]

Thanks, this will be definitely looked at 👍
(I already knew that you upgraded jackson and that is causing problems in Play, the other stuff I am not sure yet)

[pjfanning]

I had a look at one test. play.api.libs.ws.ahc.AhcWSSpec

The test case that fails involves using ahc-client to send a multipart message based on 2 sources (representing a data part and a file part). The server side receives the request but the file part parsed data is incomplete. It seems like the ahc client sends the right request data but it's possible that there could be boundary or whitespace issues that prevent the multipart parser from handling the request properly.

[gwak]

I had a look at one test. play.api.libs.ws.ahc.AhcWSSpec

The test case that fails involves using ahc-client to send a multipart message based on 2 sources (representing a data part and a file part). The server side receives the request but the file part parsed data is incomplete. It seems like the ahc client sends the right request data but it's possible that there could be boundary or whitespace issues that prevent the multipart parser from handling the request properly.

From what I understand from the Pekko migration guide, we now need to specify the Pekko stream supervision strategy explicitly when using the splitWhen function.

the following code:

playframework/core/play/src/main/scala/play/core/parsers/Multipart.scala

Line 76 in 7abd258

.splitWhen(_.isLeft)

.splitWhen(_.isLeft)
.prefixAndTail(1)

should now be:

.splitWhen(_.isLeft)
.withAttributes(ActorAttributes.supervisionStrategy(Supervision.resumingDecider))
.prefixAndTail(1)

[gwak]

@pjfanning There's another occurence of that function here:

playframework/web/play-filters-helpers/src/main/scala/play/filters/csrf/CSRFActions.scala

Line 187 in 7abd258

.splitWhen(_ => false)

[pjfanning]

@gwak @mkurz I'm not sure if #12793 has helped. The tests still seem broken. #12793 is probably ok to keep but there might be more to the pekko 1.1 issues than that.

[gwak]

@gwak @mkurz I'm not sure if #12793 has helped. The tests still seem broken. #12793 is probably ok to keep but there might be more to the pekko 1.1 issues than that.

Hi @pjfanning I just had a look into this and tested with the 1.1.x Pekko release. This is what I tried but did not pass the MultiFormDataParserSpec:

.splitWhen(_.isLeft)
.withAttributes(ActorAttributes.supervisionStrategy(Supervision.resumingDecider))
.prefixAndTail(1)

But when using the deprecated SubstreamCancelStrategy it works fine:

.splitWhen(SubstreamCancelStrategy.drain)(_.isLeft)

So it seems that either the migration guide does not fully explain how to get the old behaviour back or there're still unresolved bugs in Pekko 1.1 ?

• Support Supervision.restart for SubFlow's apache/pekko#981
• Fix uncaught decider exception in Split with Supervision.resumingDecider apache/pekko#1207
• Replace SubstreamCancelStrategy with SupervisionDecider for Split apache/pekko#252
• SubFlow's don't correctly propagate Supervision.resumeStrategy apache/pekko#1205

@mkurz Maybe we should just use the "deprecated" way of setting the cancel strategy for now until it's resolved in Pekko ?

.splitWhen(SubstreamCancelStrategy.drain)(_.isLeft)

[pjfanning]

@gwak @mdedetrich b447af5 fixed a lot of tests. There are still some other failures but I think at least one of them relates to upgrading Jackson (so unrelated to the internal Pekko changes).

[mkurz]

@gwak @mdedetrich b447af5 fixed a lot of tests. There are still some other failures but I think at least one of them relates to upgrading Jackson (so unrelated to the internal Pekko changes).

yes the failing tests having nothing to do with pekko anymore, they are all about the jackson upgrade.

[pjfanning]

Pekko 1.1.0 is out. Pekko HTTP 1.1.0 is not yet released but could possibly be released within a couple of weeks.

The main thing blocking this is the fact that Play does not support the recent versions of Jackson - and Pekko 1.1.0 uses Jackson 2.17.

[error] 	play.api.data.FormUtilsSpec
[error] 	play.it.http.parsing.JacksonJsonBodyParserSpec