Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build both pnpm and yarn images #47

Merged
merged 4 commits into from
Sep 13, 2024
Merged

Build both pnpm and yarn images #47

merged 4 commits into from
Sep 13, 2024

Conversation

davisagli
Copy link
Sponsor Member

What I'm trying to do here (not yet tested):

  1. Rename the existing yarn-based images to be released with a -yarn suffix on the version (e.g. plone/plone-frontend:18.0.0-alpha.42-yarn`). Also update the prod image to use Node 20.
  2. Update the images that are released without a suffix to use the new approach from First implementation kitconcept/plone-frontend#1, using pnpm and cookieplone instead of the old generator.
  3. Remove the nightly image (it was already disabled, and would take some work to update).

Copy link
Member

@sneridagh sneridagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sneridagh sneridagh merged commit 1b96d0b into 18.x Sep 13, 2024
4 checks passed
@sneridagh sneridagh deleted the pnpm-and-yarn-images branch September 13, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants