Core js splitting - second part #6310
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for plone-components canceled.
|
pnicolli
requested changes
Sep 27, 2024
packages/volto/src/components/theme/Widgets/DatetimeWidget.test.js
Outdated
Show resolved
Hide resolved
|
@ichim-david @sneridagh pr is ready for review. Unfortunatly a cypress test for 'locking' fails, but i don't understand why... no code related to locking is touched by this pr.. do you have some idea? |
|
@giuliaghisini maybe it's a flaky test that passes after a re run or increase of wait timer. I will have a look at this next week when I'm back to work, right now I'm waiting for the flight delay to pass :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.