[data] string representations of text in 80f59c8.s #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnonymousRandomPerson
approved these changes
Sep 24, 2023
SethBarberee
approved these changes
Sep 24, 2023
|
Needs rebase |
rpadaki
force-pushed
the
rpadaki/stringify-80f9c8
branch
from
2dad6d7
to
e097096
Compare
|
Same issues on CI as #159 |
rpadaki
force-pushed
the
rpadaki/stringify-80f9c8
branch
from
e097096
to
7caa4cb
Compare
rpadaki
changed the title
rpadaki
force-pushed
the
rpadaki/stringify-80f9c8
branch
from
7caa4cb
to
03673db
Compare
SethBarberee
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote a hacky little script to generate a tree representation of charmap and apply it across a file. Lots of manual intervention needed to mark
.byteentries which are not actually strings, and came across a few characters which hadn't been caught yet (e.g. the NDS Y button). Also fixed up some data boundaries.This PR takes all of the text inside
data_80F59C8.sand represents it as.string.