code_8073CF0 #212
code_8073CF0 #212
Conversation
|
Ready for review |
| @@ -108,4 +108,12 @@ enum DungeonID | |||
| NUM_DUNGEONS | |||
| }; | |||
|
|
|||
| static inline bool8 IsClientOrTeamBase(s32 joinedDungeon) | |||
There was a problem hiding this comment.
This function occurs in a number of other places under the name JoinLocationCannotUseItems. Perhaps those usages can be combined here too?
There was a problem hiding this comment.
Sure, I could do that. What about the name, which one you find better? Or maybe you have a better idea for the name : D
There was a problem hiding this comment.
I went with IsClientOrTeamBase
There was a problem hiding this comment.
I originally named JoinLocationCannotUseItems for an inline function related to items, but we've now found other occurrences that aren't item-related, like determining whether a Pokémon can gain experience. I'm not sure where DUNGEON_RESCUE_TEAM_BASE is used, so I like a literal name like IsClientOrTeamBase better as well.
WIP