-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mateon 2024 sep #215
Mateon 2024 sep #215
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also something to consider while naming string variables. In pokeemerald we usually follow the convention of gText_
Maybe it would be a good idea to have something similar done in this repo as well?
Not opposed to it. I'm not heavily one side or another, to be honest. |
Sorry for the delay, review comments addressed, should be ready for merge. |
Not really for or against the |
Major renames, script callbacks, cleanup