Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new feature - Picklist selectable #16045

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

EnricoMessall
Copy link
Contributor

@EnricoMessall EnricoMessall commented Jul 17, 2024

Feature Requests

Support Selectable state in PickList equal to DragDrop.

Matching discussion with more informations:
https://github.com/orgs/primefaces/discussions/2334

 + Added picklist selectable boolean to disable selection
 + Added some docs
Copy link

vercel bot commented Jul 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 9:26am
primeng-v18 ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 9:26am

@rosenthalj
Copy link
Contributor

rosenthalj commented Jul 17, 2024

Original comment I made concerning angular v17 compatibility was incorrect.

@EnricoMessall
Copy link
Contributor Author

@rosenthalj Do you mean because of https://v17.angular.io/guide/control_flow?

Its developer preview in v17 and should work already, since it has not changed for v18. I also have a v17 project where i already use the new control flow

@rosenthalj
Copy link
Contributor

@rosenthalj Do you mean because of https://v17.angular.io/guide/control_flow?

Its developer preview in v17 and should work already, since it has not changed for v18. I also have a v17 project where i already use the new control flow

@EnricoMessall
You're right, my bad. PR #16045 should be compatible with both Angular v17 and Angular v18. This is the first change I've reviewed that used control_flow which is supported in Anuglar v17.

@cetincakiroglu
Copy link
Contributor

Hi,

This PR will be reviewed in v18. Thanks for the effort and support!

@cetincakiroglu cetincakiroglu added Status: Pending Review Issue or pull request is being reviewed by Core Team Status: Discussion Issue or pull request needs to be discussed by Core Team labels Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Discussion Issue or pull request needs to be discussed by Core Team Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants