Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change .innerHTML assignments in table.ts to .textContent #16154

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

aaronshim
Copy link
Contributor

@aaronshim aaronshim commented Aug 1, 2024

Fixes #16153 in tables.ts

Copy link

vercel bot commented Aug 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Aug 1, 2024 2:16pm

@cetincakiroglu cetincakiroglu added the good first issue *** Welcome to PrimeNG Family! *** Good issue! label Aug 8, 2024
@cetincakiroglu cetincakiroglu merged commit ba12baf into primefaces:master Aug 8, 2024
2 of 3 checks passed
@ymg2006
Copy link
Contributor

ymg2006 commented Aug 11, 2024

Fixes #16153 in tables.ts

I strongly advise you to peruse innerhtml-vs-innertext-vs-textcontent.
This breaks whole rendered table CSS and ids.

@aaronshim
Copy link
Contributor Author

Discussion in #16211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue *** Welcome to PrimeNG Family! *** Good issue!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Component: Table may have Trusted Types incompatibilities from .innerHTML assignment
4 participants