Fix --int-arg, --bool-arg, etc options parsing #35249
Open
+110
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. Analyzed 7 of 7 files. Overall, the semantic diff is 28% smaller than the GitHub diff.
|
github-actions
bot
added
tests
matter-1.4-te2-script-change
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple and
kkasperczyk-no
pullapprove
bot
requested review from
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yufengwangca
|
PR #35249: Size comparison from 5bff3a5 to fd64859 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #35249: Size comparison from 5bff3a5 to 97a4fa1 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tcarmelveilleux
requested changes
Aug 28, 2024
There was a problem hiding this comment.
Please fix after SVE since the test_parameters config in TH is an arguments dict which means if --string-arg a:foo b:far shows as:
{
"string-args": "a:foo b:bar"
}
Therefore:
{
"string-arg": "a:foo",
"string-arg": "b:bar"
}
would lead to only b:bar existing :(
if we split, then TH can no longer support any tests that has multiple options of same type :(. This is horrendous, but it's more distruptive to change it right now than to leave it.
This is correct. We can add the changes needed in TH to our backlog, but I defer to @raju-apple regarding the priority. |
|
@tcarmelveilleux I've updated this PR little bit. Now it will support both option types: multi-argument and multi-option. Also, I've added a unit test to verify that both these behaviors work as expected. What do you think about such compromise? |
|
PR #35249: Size comparison from 83159c2 to e2d6538 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Multi-argument options are non-intuitive (even our manual did not document it right: https://github.com/project-chip/connectedhomeip/blob/master/docs/testing/python.md#running-tests). Instead of that, use multi-options (which aligns with the manual) while preserving possibility to use multi-argument option style to be compatible with TH.
Testing
CI will verify potential failures.