[HVAC] Thermostat deadband handling #35673
Open
+440
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. Analyzed 1 of 2 files.
|
github-actions
bot
added
app
tests
matter-1.4-te2-script-change
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex and
harsha-rajendran
pullapprove
bot
requested review from
tima-q,
tobiasgraf,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #35673: Size comparison from afb1a33 to 0b61230 Increases above 0.2%:
Full report (43 builds for bl602, bl702, bl702l, cyw30739, linux, nrfconnect, nxp, psoc6, qpg, stm32)
|
tcarmelveilleux
approved these changes
Sep 19, 2024
|
PR #35673: Size comparison from afb1a33 to 8b0f0cf Increases above 0.2%:
Full report (80 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
|
PR #35673: Size comparison from afb1a33 to b3bbfa2 Increases above 0.2%:
Full report (82 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
cjandhyala
reviewed
Sep 23, 2024
src/python_testing/TC_TSTAT_2_3.py
Outdated
There was a problem hiding this comment.
there is not test case TSTAT_2.3 defined in the test plan, the code inside this file is for TC_TSTAT_2_2. The test steps in test script are not matching with test plan steps for 2.2 test case.
There was a problem hiding this comment.
Updated to 2.3, which is in https://github.com/CHIP-Specifications/chip-test-plans/pull/4694
There was a problem hiding this comment.
See https://github.com/CHIP-Specifications/chip-test-plans/pull/4694 for test plan
There was a problem hiding this comment.
Let's wait for pan to merge
tcarmelveilleux
approved these changes
Sep 26, 2024
|
PR #35673: Size comparison from db11057 to 6a4a0ed Increases above 0.2%:
Full report (11 builds for cc32xx, nrfconnect, nxp, stm32, tizen)
|
|
PR #35673: Size comparison from db11057 to 3d70846 Increases above 0.2%:
Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This syncs the deadband handling behavior in thermostat-server with the spec; instead of rejecting any setpoint writes which violate the deadband, it attempts to shift the complementary setpoint to preserve the deadband, only erroring if this violates the min/max for the setpoint.
It also includes a new test script to verify this behavior.