Add Lifecycle finalized events triggered before starting the node #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should finalize/migrate ACL before we start the node. Also useful for other cases when we need to have these in the final data to make sure wwe do not change after someone already tries to connect.
|
Review changes with SemanticDiff. Analyzed 3 of 3 files. Overall, the semantic diff is 2% smaller than the GitHub diff.
|
pullapprove
bot
requested review from
lauckhart,
turon,
vves and
woody-apple
lauckhart
requested changes
Sep 19, 2024
| /** | ||
| * Emits when the node is finalized and goes online next | ||
| */ | ||
| get finalized() { |
There was a problem hiding this comment.
I'm wondering if we can avoid adding the event, it doesn't seem very general purpose. Why do we initialize AccessControlManager when the node comes online rather than when AccessControlServer initializes?
Is it just because FabricManager isn't available until the node is online, and we need that to perform the upgrade from 0.7? In my ClientNode branch I pulled FabricManager initialization into node startup, so if that's the problem maybe I could push that so AccessManager initialization could happen sooner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should finalize/migrate ACL before we start the node. Also useful for other cases when we need to have these in the final data to make sure wwe do not change after someone already tries to connect.