Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Cluster Remains in Generated Files After Custom XML Removal #1387

Open
dhchandw opened this issue Aug 1, 2024 · 0 comments
Open

Custom Cluster Remains in Generated Files After Custom XML Removal #1387

dhchandw opened this issue Aug 1, 2024 · 0 comments
Assignees
@brdandu @dhchandw
Labels
bug Something isn't working

Comments

@dhchandw
Copy link
Collaborator

dhchandw commented Aug 1, 2024

In ZAP, when a custom XML with a custom cluster is loaded into a Matter session, and an endpoint is configured to have this custom cluster toggled on, the generated files incorrectly retain the custom cluster even after the XML is deleted from the session.

Steps to Reproduce:

  • Open a ZAP matter session.
  • Load a custom XML that includes a custom cluster.
  • Create an endpoint and configure it to have the custom cluster toggled on.
  • Delete the custom XML from the session.
  • Generate the files.

Expected Behavior:
The generated files should not include the custom cluster after the XML is deleted from the session.

Actual Behavior:
The generated files incorrectly still include the custom cluster, even though the XML has been removed. This is only noticed in the dynamic files (endpoint-config.c, endpoints.out, ...)
@dhchandw dhchandw added the bug Something isn't working label Aug 1, 2024
@dhchandw dhchandw mentioned this issue Aug 5, 2024
Merged
dhchandw added a commit that referenced this issue Aug 6, 2024
@dhchandw
Adding tests for Matter custom xml support (#1389)
daf08e8 
Added tests for Matter custom xml support for the following use cases:

- loads a file with a custom cluster and an extension of a cluster and checks it
- loads a second file with a further extension of the extended cluster and checks it
- tests generation with custom xml
- loading bad custom xml -> throw warning
- Add 2 custom files with manufacturer name/code and attribute code collisions -> throw error.
    * This should be an SQL error, it is currently broken and should be fixed in PR Adding constraints to the database       tables to avoid redundant entries #1352 is merged.
- test generation after deleting the custom xml
     * This doesn't work as expected - #1387
- Add custom xml, make changes, delete, add again -> make sure that generated content has new edits
      * Effected by #1387 and #1391
- Loading zap file with custom xml that does not exist - throw error
- Loading zap file with custom xml and generating

Once PR #1352 is merged and #1387 and #1391 are resolved - tests should be updated appropriately.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brdandu brdandu

@dhchandw dhchandw

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brdandu @dhchandw