Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tests for Matter custom xml support #1389

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

dhchandw
Copy link
Collaborator

@dhchandw dhchandw commented Aug 5, 2024

Added tests for Matter custom xml support for the following use cases:

Once PR #1352 is merged and #1387 and #1391 are resolved - tests should be updated appropriately.

@dhchandw dhchandw marked this pull request as ready for review August 5, 2024 16:36
Copy link
Collaborator

@brdandu brdandu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • One edge case worth consideration is if the custom xml path is valid but does not exist in the database. what happens? We have users sometime deleting the .zap repo and then opening their .zap files. Ideally that behavior should not break ZAP. Worth testing that as well. Approving the PR however if you want to merge and add that later.
  • Also link this PR to your issue for easy reference in the future.
  • You have pretty good description on the PR. Add that to your git commit message it is useful information. Also add the git/jira issue associated with your PR to the git commit eg(JIRA: ZAPP-123 or Github: ZAP#123)

@dhchandw dhchandw merged commit daf08e8 into project-chip:master Aug 6, 2024
13 checks passed
@dhchandw dhchandw deleted the test/matterCustomXmlTest branch August 22, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants