allow words to be in the template #169
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwisiswant0
requested changes
Aug 30, 2024
| payloadSet[v] = append(payloadSet[v], word) | ||
| } | ||
| } | ||
| payloadSet[v] = append([]string{}, m.Options.Payloads[v]...) |
There was a problem hiding this comment.
Instead of removing the !strings.Contains condition that's already in place, it would be better to enhance it by performing a comparison check where if the word is eq to sub, then just continue.
Also don't forget to add/update the test case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #168
The check
strings.Contains(template, word)has lots of unintended consequences.Examples:
api-pizzapie.site.comwould not be allowed aspizzapiecontainsapisite-api.site.comwould not be allowed assiteis in the template{{word}}-api.site.comdev-api.site.devwould not be allowed asdevis in the template{{word}}-api.site.devI thought about adding a command option or adding a more complex check but decided just removing it is better.
I don't think the optimization saves much anyway, DNS requests are cheap.