Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set read and write deadline #3845

Merged
merged 2 commits into from
Jun 28, 2023
Merged

set read and write deadline #3845

merged 2 commits into from
Jun 28, 2023

Conversation

praetorian-thendrickson
Copy link
Contributor

Proposed changes

Change setReadDeadline to setDeadline (for read/write)

In reference to this issue:

#3762

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes

@ehsandeep ehsandeep linked an issue Jun 19, 2023 that may be closed by this pull request
missing deadline on network write causes delay #3762
Closed
2 tasks
@olearycrew
Copy link
Contributor

Thanks for this contribution @praetorian-thendrickson !

@ehsandeep ehsandeep added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jun 20, 2023
@Mzack9999 Mzack9999 self-requested a review June 22, 2023 08:32
@ehsandeep ehsandeep added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Jun 23, 2023
@ehsandeep ehsandeep deleted the branch projectdiscovery:dev June 27, 2023 16:30
@ehsandeep ehsandeep closed this Jun 27, 2023
@ehsandeep ehsandeep reopened this Jun 27, 2023
Mzack9999
Mzack9999 approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - nice one, this prevents also blocking write i/o

@Mzack9999 Mzack9999 merged commit 060206e into projectdiscovery:dev Jun 28, 2023
10 of 11 checks passed
@ehsandeep ehsandeep removed the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees
No one assigned
Labels
Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

missing deadline on network write causes delay
4 participants
@praetorian-thendrickson @olearycrew @Mzack9999 @ehsandeep