fix race condition #5547
Merged
fix race condition #5547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
perf test passes https://github.com/projectdiscovery/nuclei/actions/runs/10460146436 |
Mzack9999
requested changes
Aug 20, 2024
There was a problem hiding this comment.
I've tried to execute locally and it seems like we have other few race conditions, for example:
==================
WARNING: DATA RACE
Write at 0x000111024d50 by goroutine 51:
github.com/projectdiscovery/nuclei/v3/pkg/protocols/common/protocolstate.Close()
/Users/user/go/src/github.com/projectdiscovery/nuclei/pkg/protocols/common/protocolstate/state.go:217 +0x84
github.com/projectdiscovery/nuclei/v3/pkg/protocols/common/protocolinit.Close()
/Users/user/go/src/github.com/projectdiscovery/nuclei/pkg/protocols/common/protocolinit/init.go:41 +0x1c4
github.com/projectdiscovery/nuclei/v3/internal/runner.(*Runner).Close()
/Users/user/go/src/github.com/projectdiscovery/nuclei/internal/runner/runner.go:380 +0x1bc
main.main.func4()
/Users/user/go/src/github.com/projectdiscovery/nuclei/cmd/nuclei/main.go:165 +0x11c
Previous read at 0x000111024d50 by goroutine 71255:
github.com/projectdiscovery/nuclei/v3/pkg/protocols/http/httpclientpool.wrappedGet()
/Users/user/go/src/github.com/projectdiscovery/nuclei/pkg/protocols/http/httpclientpool/clientpool.go:236 +0x764
github.com/projectdiscovery/nuclei/v3/pkg/protocols/http/httpclientpool.Get()
/Users/user/go/src/github.com/projectdiscovery/nuclei/pkg/protocols/http/httpclientpool/clientpool.go:154 +0x124
github.com/projectdiscovery/nuclei/v3/pkg/protocols/http.(*Request).executeRequest()
/Users/user/go/src/github.com/projectdiscovery/nuclei/pkg/protocols/http/request.go:787 +0x28da
github.com/projectdiscovery/nuclei/v3/pkg/protocols/http.(*Request).ExecuteWithResults.func1()I think we should also consider in a follow up issue to disable the panic-recover mechanism in GitHub Actions, where not necessary. Otherwise, errors are not detected. The app should just crash to ensure failures are visible.
I couldn't repro this, but I removed the redundant nil assignment here: 35a0d67. Could you re-run and see if it happens again? |
Mzack9999
reviewed
Aug 21, 2024
This reverts commit 35a0d67.
Mzack9999
approved these changes
Aug 21, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Closes #5534
Checklist