Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upload existing scan results #5603

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Conversation

RamanaReddy0M
Copy link
Contributor

@RamanaReddy0M RamanaReddy0M commented Sep 5, 2024

Proposed changes

Test:

$ ./nuclei -pdu out.jsonl -sname "<scan-name>"

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@RamanaReddy0M RamanaReddy0M self-assigned this Sep 5, 2024
Copy link
Member

@dogancanbakir dogancanbakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ go run . -pdu result.jsonl -sname 'pdcp-upload-test'

                     __     _
   ____  __  _______/ /__  (_)
  / __ \/ / / / ___/ / _ \/ /
 / / / / /_/ / /__/ /  __/ /
/_/ /_/\__,_/\___/_/\___/_/   v3.3.2

                projectdiscovery.io

[INF] Uploading scan results to cloud dashboard from result.jsonl
[INF] 3 Scan results uploaded to cloud, you can view scan results at https://cloud.projectdiscovery.io/scans/crcmh0todknc73bvbm20?team_id=none
image

Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

team id env value not used

var (
xidRegex = regexp.MustCompile(xidRe)
_ output.Writer = &UploadWriter{}
// teamID if given
TeamIDEnv = env.GetEnvOrDefault("PDCP_TEAM_ID", NoneTeamID)
)

apart from that everything else lgtm !

@RamanaReddy0M
Copy link
Contributor Author

team id env value not used

var (
xidRegex = regexp.MustCompile(xidRe)
_ output.Writer = &UploadWriter{}
// teamID if given
TeamIDEnv = env.GetEnvOrDefault("PDCP_TEAM_ID", NoneTeamID)
)

apart from that everything else lgtm !

We are using here!

@ehsandeep ehsandeep merged commit bd6330f into dev Sep 12, 2024
11 of 12 checks passed
@ehsandeep ehsandeep deleted the issue-5585-upload-existing-results branch September 12, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] upload local / existing nuclei results to dashboard
4 participants