Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CAT-1404)- Fix rubocop nightly failures #151

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

gavindidrichsen
Copy link

@gavindidrichsen gavindidrichsen commented Sep 12, 2023

Summary

Regenerate the .rubocop_todo.yml using bundle exec rubocop --auto-gen-config

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

@gavindidrichsen gavindidrichsen force-pushed the cat-1404-fix_rubocop_nightly_failures branch from e9e2662 to de0284c Compare September 12, 2023 12:16
@gavindidrichsen gavindidrichsen marked this pull request as ready for review September 12, 2023 13:08
@gavindidrichsen gavindidrichsen marked this pull request as draft September 12, 2023 14:03
@gavindidrichsen gavindidrichsen force-pushed the cat-1404-fix_rubocop_nightly_failures branch from de0284c to e125e0a Compare September 12, 2023 15:55
@gavindidrichsen gavindidrichsen marked this pull request as ready for review September 12, 2023 15:58
@gavindidrichsen
Copy link
Author

gavindidrichsen commented Sep 12, 2023

Hi @bastelfreak. Thanks for the approval on my last submission! After some discussion locally, we found that (1) simply regenerating the .rubocop_todo.yml fixed the tests and (2) decided not to do any rubocop version uplifts unless we do it as part of a consistent sweep across all our tools, etc.

If you're still ok with this latest change (minus the update to the Gemfile), then let me know.

Thanks again.

@gavindidrichsen gavindidrichsen force-pushed the cat-1404-fix_rubocop_nightly_failures branch from e125e0a to fa3e3fb Compare September 12, 2023 16:18
@david22swan david22swan merged commit 1b86e15 into main Sep 13, 2023
6 checks passed
@david22swan david22swan deleted the cat-1404-fix_rubocop_nightly_failures branch September 13, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants